Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D076110493 for ; Mon, 12 Jan 2015 22:57:54 +0000 (UTC) Received: (qmail 74411 invoked by uid 500); 12 Jan 2015 22:57:56 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 74378 invoked by uid 500); 12 Jan 2015 22:57:56 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 74361 invoked by uid 99); 12 Jan 2015 22:57:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Jan 2015 22:57:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 33C3A1D238F; Mon, 12 Jan 2015 22:57:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6250234713824591696==" MIME-Version: 1.0 Subject: Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart From: "Nate Cole" To: "Nate Cole" , "Dmitro Lisnichenko" , "Yurii Shylov" Cc: "Alejandro Fernandez" , "Ambari" Date: Mon, 12 Jan 2015 22:57:53 -0000 Message-ID: <20150112225753.23996.19983@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29790/ X-Sender: "Nate Cole" References: <20150112201317.23996.1612@reviews.apache.org> In-Reply-To: <20150112201317.23996.1612@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============6250234713824591696== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 12, 2015, 3:13 p.m., Nate Cole wrote: > > Many of the clients have symlinks as noted. Fix if needed then Ship It. > > Alejandro Fernandez wrote: > These are the component names in hdp-select, as opposed to the symlink name in /usr/hdp/current. > I'll investigate why they dont coincide. Ah ok. If this is the only way, then you can mark them all resolved and push. Thanks! - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29790/#review67691 ----------------------------------------------------------- On Jan. 12, 2015, 4:25 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29790/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 4:25 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov. > > > Bugs: AMBARI-9081 > https://issues.apache.org/jira/browse/AMBARI-9081 > > > Repository: ambari > > > Description > ------- > > See AMBARI-8995, after that changes master components have their version in the results of START command, but clients do not execute this command and thus it's not possible to track their new version. As the result some components of the cluster remain in non upgraded state and it prevents from setting cluster to upgraded state and finalize upgrade. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/libraries/script/script.py af02f378384a40026181b7d408e740fd2fcdd791 > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 5c430df673dddbdd88e32577d395836b2bfa45c6 > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py 6f37f506e93f3f42e6e89851453e776eef38b178 > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 59dba8d867e0ab3bc46db39876da42b9846a681f > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py 3f19ce41d95faf675df183cdda48110c515b9885 > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 570b1246be55e3147a17dd6927bd7f6119bf62dc > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py 72b657f3cd62b47a7146d9d2e2d7df478cfbaad7 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 50bd822ea211a7a767495c1d61bde0af87b736e3 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 59be175a3134b540122d8ca4ab99ece840d578f5 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 6d8716f35093b68a5ebaffbf5bb764884f6eb630 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 6b88acb6b7ec6ea83b196ac4f501db15c8b4544b > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py a62529538d0cf2770bd5c6647895f5e2530834f8 > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 5fc27f4f938b9e61c6c46bab51554f071b0f51fa > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py a11a0b6d23a3fbbca9b2ce5a86de5f6db9382cbf > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 568ee8ecac052fcc9c00b808d56cd9117f8f0230 > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 878b50cd720645d6e10a11442d8c281df5c545d2 > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py ecd41c5ad1a0159f3646671fc7ed28a2407e4833 > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py b447003ed4b21feb4a07041c50ab19802dc687a1 > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 9a3eb669dd9fe360d0d35f0bbcd663a47fa5d46a > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py a43bda556db847fadf4613d583854318d6668908 > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py d7bf5eb8b0ca7cef0c5843a0cc83273d63075b37 > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py 2dd38352f8bbf03ad25855f72a4563383274d07e > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 5218f490dbbdae4c79e7e52a311a6d4582a0a030 > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py 33ced03a6ee8cd2ea80df0b41dc8fbe007777f79 > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py db8f18889fb724f41567f3e03edbf0a90a10a171 > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010f90c9b459f5ba0595d54956cd8818e21f > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py f70f67bdf2898f5779f100ff54b9a94fda2e6dba > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py ef8b95e080a4dc297838ee68a55ed17f70aba720 > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py 13ab77fe8669806e27ad7da6d12350496971e894 > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 04cfb906a59fb70074272f9f33aa9bf36e844fb0 > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py a8ead39419ad472ea3863bc1b4517e86e89efbb5 > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py c4e28000049c7278a84e2b7fab732fe99d4b8bcb > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 78a75f6e9182567b588816bcc83524f33028d6c0 > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 2b8c6316e9f0366bbc774157d0d49a3041e0cd12 > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py 60b9bce8c86393b7d375b65ccabd5cfaecd0980e > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py 7d5798329d05b02ad0ce7e8878fec44782e29750 > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py 626ceba5d8b1662342310e65679174a9b36024b1 > > Diff: https://reviews.apache.org/r/29790/diff/ > > > Testing > ------- > > Copied files to a cluster, and verified that restarting the services showed the version in structured_out of the host_role_command table. > > mvn clean test > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 30:31.481s > [INFO] Finished at: Mon Jan 12 13:23:01 PST 2015 > [INFO] Final Memory: 66M/721M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Alejandro Fernandez > > --===============6250234713824591696==--