Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6284372124571501395=="
MIME-Version: 1.0
Subject: Re: Review Request 29788: Rolling Upgrade - prepare function to copy
 tarballs based on new HDP version
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Mon, 12 Jan 2015 19:13:33 -0000
Message-ID: <20150112191333.23996.63241@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20150110011905.26560.46043@reviews.apache.org>
In-Reply-To: <20150110011905.26560.46043@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>

--===============6284372124571501395==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/
-----------------------------------------------------------

(Updated Jan. 12, 2015, 7:13 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.


Changes
-------

Fixing unit tests.


Bugs: AMBARI-8917
    https://issues.apache.org/jira/browse/AMBARI-8917


Repository: ambari


Description
-------

The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943 
  ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b 
  ambari-server/src/test/python/TestAmbariServer.py 5f1fa388ff551222a534f4af1c00b34c070ec5fc 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116 

Diff: https://reviews.apache.org/r/29788/diff/


Testing (updated)
-------

Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.

Unit tests before accepting patch 01b3af1b7d191019aafc0d8d670941548a7d4b14 (Ranger support) passed.
Will re-run unit tests on ABO


Thanks,

Alejandro Fernandez


--===============6284372124571501395==--