Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============2653486788104824082=="
MIME-Version: 1.0
Subject: Re: Review Request 29814: Core Slaves shows weird step for
 AMBARI_SERVER_ACTION_EXECUTE
From: "Nate Cole" <ncole@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Nate Cole" <ncole@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Mon, 12 Jan 2015 18:13:17 -0000
Message-ID: <20150112181317.23996.55201@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20150112180840.23997.38608@reviews.apache.org>
In-Reply-To: <20150112180840.23997.38608@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>

--===============2653486788104824082==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Jan. 12, 2015, 1:08 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 694
> > <https://reviews.apache.org/r/29814/diff/1/?file=816736#file816736line694>
> >
> >     Maybe something more human readable; "Updating Hive Configuration" or "Updating Datanode Configuration"

That's why the previous check looks for a summary on the task itself.  If there's a summary added to XML, use that.  Otherwise use rather boring formatted string.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29814/#review67668
-----------------------------------------------------------


On Jan. 12, 2015, 1:06 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29814/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 1:06 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9093
>     https://issues.apache.org/jira/browse/AMBARI-9093
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For configure and manual tasks, set the stage text to a more appropriate summary, and item text to more detail.  This is to make the UI look correct for those types of tasks.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java d829e20 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9eb0d4b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java b720f18 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 0d19b76 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java cd10260 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java 171367b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 876b997 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 2bb34d6 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 2c57907 
> 
> Diff: https://reviews.apache.org/r/29814/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:11.248s
> [INFO] Finished at: Mon Jan 12 13:06:23 EST 2015
> [INFO] Final Memory: 34M/347M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


--===============2653486788104824082==--