Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8798387106254768239=="
MIME-Version: 1.0
Subject: Re: Review Request 29664: Create new API endpoints to obtain the
 stack and stack service kerberos descriptors
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Robert Levas" <rlevas@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "John Speidel" <jspeidel@hortonworks.com>
Date: Wed, 07 Jan 2015 19:57:25 -0000
Message-ID: <20150107195725.26560.59463@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
References: <20150107190202.26559.31297@reviews.apache.org>
In-Reply-To: <20150107190202.26559.31297@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>

--===============8798387106254768239==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29664/#review67065
-----------------------------------------------------------


ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
<https://reviews.apache.org/r/29664/#comment110891>

    Would it be cleaner to use a SimpleResourceDefinition? ...
    
            resourceDefinition = new SimpleResourceDefinition(Resource.Type.StackArtifact, "artifact", "artifacts");


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java
<https://reviews.apache.org/r/29664/#comment110893>

    Could this be an AbstractResourceProvider?  Does it need access to the AmbariManagementController?


- Tom Beerbower


On Jan. 7, 2015, 7:02 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29664/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 7:02 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Robert Levas, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9028
>     https://issues.apache.org/jira/browse/AMBARI-9028
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create new API endpoints for exposing stack and stack service kerberos descriptors. These endpoints will provide the static descriptors which are defined in the stack definition and will be immutable.
> There will be at most 1 descriptor for both the stack and each stack service.
> Therefore, it doesn't make sense to add a kerberos_descriptor sub-resource since there will be at most one instance.
> Instead, a new "artifacts" endpoint is being introduced.
> The kerberos descriptor will be an artifact instance.
> 
> See the associated Jira for more information.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java e55b2cb 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinition.java cb1dfb1 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java e8d4bd5 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java cdadfd9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 11b0411 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 89d6837 
>   ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 57aea49 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/StacksServiceTest.java 212eaa0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java 5414b52 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 3ef0ade 
> 
> Diff: https://reviews.apache.org/r/29664/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional Testing:
>   queried new resources including collection and instance resources, queries, partial response and bad requests
> 
> Unit Testing:
> All Java unit tests pass
> Results :
> 
> Tests run: 2492, Failures: 0, Errors: 0, Skipped: 13
> 
> Many python test failures which seem unrelated to my patch.
> I have sent an email to dev@ambari to determine if these are known issues or if I need to investigate.
> 
> Also, no unit test was written for the new StackArtifactResourceProvider due to time constraints.
> I have filed the following Jira to track this and ensure that the tests are written:
> https://issues.apache.org/jira/browse/AMBARI-9026
> 
> 
> Thanks,
> 
> John Speidel
> 
>


--===============8798387106254768239==--