Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AB7517BBE for ; Tue, 6 Jan 2015 22:07:24 +0000 (UTC) Received: (qmail 8065 invoked by uid 500); 6 Jan 2015 22:07:25 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 8034 invoked by uid 500); 6 Jan 2015 22:07:25 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 8018 invoked by uid 99); 6 Jan 2015 22:07:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2015 22:07:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 077441CAC29; Tue, 6 Jan 2015 22:07:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5942753145584008410==" MIME-Version: 1.0 Subject: Re: Review Request 29642: Add Property modal should have checkbox to toggle single or bulk property From: "Saman Alvi" To: "Saman Alvi" , "Ambari" , "Ivan Wang" Date: Tue, 06 Jan 2015 22:07:22 -0000 Message-ID: <20150106220722.26561.3784@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Saman Alvi" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29642/ X-Sender: "Saman Alvi" References: <20150106220328.26560.77045@reviews.apache.org> In-Reply-To: <20150106220328.26560.77045@reviews.apache.org> Reply-To: "Saman Alvi" X-ReviewRequest-Repository: ambari --===============5942753145584008410== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29642/#review66927 ----------------------------------------------------------- Ship it! Ship It! - Saman Alvi On Jan. 6, 2015, 10:03 p.m., Ivan Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29642/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 10:03 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-8838 > https://issues.apache.org/jira/browse/AMBARI-8838 > > > Repository: ambari > > > Description > ------- > > Add property modal should have the two buttons modified to have a description + checkbox for both of them > > > Diffs > ----- > > ambari-web/app/styles/application.less 12d363c > ambari-web/app/templates/common/configs/addPropertyWindow.hbs 61572fd > ambari-web/app/views/common/configs/service_configs_by_category_view.js 65c08e4 > > Diff: https://reviews.apache.org/r/29642/diff/ > > > Testing > ------- > > ui change, no tests > > > Thanks, > > Ivan Wang > > --===============5942753145584008410==--