Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6879835543519070484=="
MIME-Version: 1.0
Subject: Re: Review Request 29593: AMS : Yarn service - RPC metrics returns
 duplicate array elements.
From: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>
To: "Mahadev Konar" <mahadev@apache.org>,
 "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>,
 "Dmytro Sen" <dsen@hortonworks.com>
Cc: "Sid Wagle" <swagle@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Mon, 05 Jan 2015 22:33:55 -0000
Message-ID: <20150105223355.26559.9243@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Myroslav Papirkovskyy" <noreply@reviews.apache.org>
References: <20150105222929.26559.62800@reviews.apache.org>
In-Reply-To: <20150105222929.26559.62800@reviews.apache.org>
Reply-To: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>

--===============6879835543519070484==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29593/#review66735
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Січ. 6, 2015, 12:29 до полудня, Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29593/
> -----------------------------------------------------------
> 
> (Updated Січ. 6, 2015, 12:29 до полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-8994
>     https://issues.apache.org/jira/browse/AMBARI-8994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> API call:
> {code}
> http://localhost:8080/api/v1/clusters/cl1/hosts/ambari-api-tests-20-4.cs1cloud.internal/host_components/RESOURCEMANAGER?fields=metrics/rpc/RpcQueueTime_avg_time[1419970008,1419973608,15]
> {code}
> - Every 8th timestamp is duplicated.
> - AMS should be able to handle this.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java PRE-CREATION 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/base/AbstractTimelineMetricsSink.java d51ee67 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java 06c3441 
>   ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java d28b345 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java fb061a9 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 3c83868 
>   ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java a8f35e4 
> 
> Diff: https://reviews.apache.org/r/29593/diff/
> 
> 
> Testing
> -------
> 
> Results :
> 
> Tests run: 90, Failures: 0, Errors: 0, Skipped: 4
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


--===============6879835543519070484==--