Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44D99173D0 for ; Mon, 5 Jan 2015 22:29:31 +0000 (UTC) Received: (qmail 5281 invoked by uid 500); 5 Jan 2015 22:29:32 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 5242 invoked by uid 500); 5 Jan 2015 22:29:32 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 5214 invoked by uid 99); 5 Jan 2015 22:29:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jan 2015 22:29:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 09DD71CABF7; Mon, 5 Jan 2015 22:29:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2152923543409128404==" MIME-Version: 1.0 Subject: Re: Review Request 29593: AMS : Yarn service - RPC metrics returns duplicate array elements. From: "Sid Wagle" To: "Mahadev Konar" , "Myroslav Papirkovskyy" , "Dmytro Sen" Cc: "Sid Wagle" , "Ambari" Date: Mon, 05 Jan 2015 22:29:29 -0000 Message-ID: <20150105222929.26559.62800@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sid Wagle" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/29593/ X-Sender: "Sid Wagle" References: <20150105222116.26560.44626@reviews.apache.org> In-Reply-To: <20150105222116.26560.44626@reviews.apache.org> Reply-To: "Sid Wagle" X-ReviewRequest-Repository: ambari --===============2152923543409128404== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29593/ ----------------------------------------------------------- (Updated Jan. 5, 2015, 10:29 p.m.) Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy. Bugs: AMBARI-8994 https://issues.apache.org/jira/browse/AMBARI-8994 Repository: ambari Description ------- API call: {code} http://localhost:8080/api/v1/clusters/cl1/hosts/ambari-api-tests-20-4.cs1cloud.internal/host_components/RESOURCEMANAGER?fields=metrics/rpc/RpcQueueTime_avg_time[1419970008,1419973608,15] {code} - Every 8th timestamp is duplicated. - AMS should be able to handle this. Diffs ----- ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java PRE-CREATION ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/base/AbstractTimelineMetricsSink.java d51ee67 ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java 06c3441 ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java d28b345 ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java fb061a9 ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 3c83868 ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java a8f35e4 Diff: https://reviews.apache.org/r/29593/diff/ Testing (updated) ------- Results : Tests run: 90, Failures: 0, Errors: 0, Skipped: 4 Thanks, Sid Wagle --===============2152923543409128404==--