ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Siddharth Wagle <swa...@hortonworks.com>
Subject Re: Review Board not accepting patches
Date Wed, 07 Jan 2015 04:55:59 GMT
Nice work Alejandro.

Award token is equivalent to a +1.

On Tue, Jan 6, 2015 at 7:51 PM, Alejandro Fernandez <
afernandez@hortonworks.com> wrote:

> Ok, I created a free instance of a Code Review server at
> https://ambari.phoreplay.com
> Right now, you have to login to see the reviews, but it has advanced
> features to enable authentication with Jira and GitHub.
>
> E.g., https://ambari.phoreplay.com/D1
>
> The repo is currently being configured, so that it has the context and can
> make sense of the base commits.
>
> Thanks,
> Alejandro
>
>
>
> On Tue, Jan 6, 2015 at 6:57 PM, Alejandro Fernandez <
> afernandez@hortonworks.com> wrote:
>
>> Actually, don't use reviews.llvm.org, I'm trying to see if I can find an
>> instance of Phabricator that we can use.
>>
>> -Alejandro
>>
>> On Tue, Jan 6, 2015 at 6:31 PM, Alejandro Fernandez <
>> afernandez@hortonworks.com> wrote:
>>
>>> If you're still having problems uploading patches to ReviewBoard, try
>>> Phabricator (http://reviews.llvm.org/)
>>> You can login using GitHub or Gmail account.
>>>
>>> E.g., http://reviews.llvm.org/D6860
>>>
>>> If people like it, we can setup an Ambari repo on it.
>>>
>>> Thanks,
>>> Alejandro
>>>
>>> On Mon, Jan 5, 2015 at 8:06 PM, Alejandro Fernandez <
>>> afernandez@hortonworks.com> wrote:
>>>
>>>> It seems that Review Board is having trouble finding commits, so it
>>>> can't perform diffs.
>>>> error: unable to find 331af15c19e03ef68dd76993f853fb9851f063c8
>>>>
>>>> ‚Äč
>>>> I generate my patches as follows,
>>>>
>>>> if committed,
>>>> git show --full-index --format=format:%H > ~/AMBARI-####.patch
>>>>
>>>> if cached,
>>>> git diff HEAD --full-index > ~/AMBARI-####.patch
>>>>
>>>> Richard and I have been seeing this for a couple of hours now. For now,
>>>> feel free to attach the patches to the Jira until this is resolved.
>>>>
>>>> Thanks,
>>>> Alejandro
>>>>
>>>> --
>>>> [image: Hortonworks, Inc.] <http://hortonworks.com/> *Alejandro
>>>> Fernandez <afernandez@hortonworks.com>**Engineering - Ambari*
>>>> 786.303.7149
>>>>
>>>
>>>
>>>
>>> --
>>> [image: Hortonworks, Inc.] <http://hortonworks.com/> *Alejandro
>>> Fernandez <afernandez@hortonworks.com>**Engineering - Ambari*
>>> 786.303.7149
>>>
>>
>>
>>
>> --
>> [image: Hortonworks, Inc.] <http://hortonworks.com/> *Alejandro
>> Fernandez <afernandez@hortonworks.com>**Engineering - Ambari*
>> 786.303.7149
>>
>
>
>
> --
> [image: Hortonworks, Inc.] <http://hortonworks.com/> *Alejandro Fernandez
> <afernandez@hortonworks.com>**Engineering - Ambari*
> 786.303.7149
>

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.

Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message