ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 30415: Implement Keytab regeneration
Date Fri, 30 Jan 2015 15:04:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30415/#review70361
-----------------------------------------------------------

Ship it!


- Tom Beerbower


On Jan. 30, 2015, 2:24 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30415/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 2:24 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9385
>     https://issues.apache.org/jira/browse/AMBARI-9385
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create API entry point to initiate Kerberos keytab regeneration for the cluster:
> ```
> PUT /api/v1/clusters/{clustername}?regenerate_keytabs=true
> {
>   "Clusters" : {
>     "security_type" : "KERBEROS"
>   }
> }
> ```
> 
> The entry point should invoke code to determine which principals need to be updated and
then generate the following stages:
> # Update Principal Passwords
> # Generate Keytabs
> # Distribute Keytab
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
9b744d0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
e867f99 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
6bb9bf1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
1a66cd9 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
e976d81 
> 
> Diff: https://reviews.apache.org/r/30415/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in cluster again MIT KDC (Active Directory pending)
> Updated unit tests
> 
> # Jenkins test results
> Running org.apache.ambari.server.controller.AmbariManagementControllerImplTest
> Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.099 sec
> 
> Running org.apache.ambari.server.controller.KerberosHelperTest
> Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.626 sec
> 
> Ambari-server test results
> Tests run: 2631, Failures: 0, Errors: 0, Skipped: 15
> 
> **Note: Python tests are broken on the trunk, unrelated to this change**
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message