ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 30429: Allow cluster and service artifacts to be updated and deleted
Date Fri, 30 Jan 2015 09:52:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30429/#review70341
-----------------------------------------------------------

Ship it!


Looks good.

- Tom Beerbower


On Jan. 29, 2015, 10:32 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30429/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 10:32 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9410
>     https://issues.apache.org/jira/browse/AMBARI-9410
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow artifact resource for cluster and service to be updated and deleted via the api.
> Adds update and delete functionality to the endpoints:
> /clusters/api/v1/clusters/:clusterName/artifacts
> /clusters/api/v1/clusters/:clusterName/services/:serviceName/artifacts
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
5f44b2f 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
8a2642b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
e476f62 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ArtifactDAO.java 4b7cf25

>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterServiceTest.java
c8f020e 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ServiceServiceTest.java
5ca3fb3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ArtifactResourceProviderTest.java
046c5d8 
> 
> Diff: https://reviews.apache.org/r/30429/diff/
> 
> 
> Testing
> -------
> 
> Manual functional testing including updating and deleting cluster and service artifacts.
> Unit Tests:
> - added new tests
> - all tests pass
> 
> Tests run: 2630, Failures: 0, Errors: 0, Skipped: 15
> ...
> Total run:586
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message