ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yurii Shylov" <yurii.shy...@gmail.com>
Subject Re: Review Request 30366: Safety meassures: autoremove only packages that have repo version at their name
Date Wed, 28 Jan 2015 20:02:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30366/#review70063
-----------------------------------------------------------

Ship it!


Ship It!

- Yurii Shylov


On Янв. 28, 2015, 3:26 п.п., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30366/
> -----------------------------------------------------------
> 
> (Updated Янв. 28, 2015, 3:26 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9375
>     https://issues.apache.org/jira/browse/AMBARI-9375
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing distribute repositories/install packages action, we install some packages
one by one. If installation of some package fails, all previously installed packages are removed.
> The risk here is to accidentally (e.g. in case of script bug) remove some essential packages.
> We might want to add some check to remove only packages that have stack version string
in their name. Removing them should be enough in most cases since shared packages tend to
be installed from HDP-UTILS repo.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 83c8037

>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 0ad56c8 
> 
> Diff: https://reviews.apache.org/r/30366/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [5.219s]
> [INFO] Ambari Server ..................................... SUCCESS [31.319s]
> [INFO] Ambari Agent ...................................... SUCCESS [16.358s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 55.612s
> [INFO] Finished at: Wed Jan 28 18:23:18 FET 2015
> [INFO] Final Memory: 41M/420M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message