ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 30332: Request status may be FAILED if underlying skippable stage is FAILED.
Date Wed, 28 Jan 2015 13:27:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30332/#review70005
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Jan. 27, 2015, 5:37 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30332/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 5:37 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-9362
>     https://issues.apache.org/jira/browse/AMBARI-9362
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> A skippable stage means that it can fail without the entire request failing.  Currently
the calculation for request status may return FAILED if an underlying stage is FAILED, even
if that stage is skippable.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
c0fdd1d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
54e65fa 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java
4288627 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java f1c7832

>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
3ab609d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
87398a5 
> 
> Diff: https://reviews.apache.org/r/30332/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> New unit tests added.
> All tests pass.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:48 min
> [INFO] Finished at: 2015-01-27T16:57:05-05:00
> [INFO] Final Memory: 42M/636M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message