ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 30342: Handle hosts/services/components being added to a kerberized cluster
Date Wed, 28 Jan 2015 03:09:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30342/#review69948
-----------------------------------------------------------

Ship it!


Looks good.

- Robert Levas


On Jan. 27, 2015, 7:35 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30342/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 7:35 p.m.)
> 
> 
> Review request for Ambari, Robert Levas and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9364
>     https://issues.apache.org/jira/browse/AMBARI-9364
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When adding components to a kerberized cluster we need to ensure that the necessary kerberos
related tasks are executed such as keytab generation ...
> As a result of this work, we will be able to add hosts, services and components to a
kerberized cluster via the UI or API and all of the necessary kerberos tasks will be executed
for the add to be successful.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
c537498 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
7c7e280 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
758e741 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
c6a89ed 
> 
> Diff: https://reviews.apache.org/r/30342/diff/
> 
> 
> Testing
> -------
> 
> Manual functinal testing of adding a host via the UI to a kerberized cluster.
> Unit tests:
> Added new unit tests
> All tests pass
> 
> Results :
> 
> Tests run: 2621, Failures: 0, Errors: 0, Skipped: 15
> ...
> Total run:584
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message