ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 30306: RU - Cluster install did not transition cluster_version to CURRENT because host has only AMS
Date Tue, 27 Jan 2015 21:35:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30306/#review69889
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/30306/#comment114720>

    No reason you can't also pass in the cluster here to the constructor of the HostComponentVersionEvent
so that the event doesn't need to do the lookup.


- Jonathan Hurley


On Jan. 27, 2015, 3:49 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30306/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 3:49 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9340
>     https://issues.apache.org/jira/browse/AMBARI-9340
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> New cluster install through the Install Wizard correctly transitioned all of the host_versions
into CURRENT, but did not propagate the changes to the cluster_version, which stayed stuck
on UPGRADING, because one host only had AMS, so it could not create a host_version record.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 092f9d54db36686412d7ccaa3318330688cf67cd

>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
7924ba8494fbed595e5419bee4eae1c2facbeba6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
1ad0a0a261f596dad7271e26dd197ea755c715c9 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 7944908d4cdb9d10cf27fcd8b5e580471960b48d

>   ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java f79db0ccc072cd600ba29bcb2f69292baf7dbdf1

>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 159408f7d0adadd7e394a03c3d08a36556b325f7

>   ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java cbf16e3d02ee32d8885cb896810f866d7ca60157

>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
c8abdf214d3074de165d11a14ec28c644a428f0b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
372325df8b1e1191b87441304dc9a994f8b56f72 
>   ambari-server/src/main/resources/common-services/AMS/0.1.0/metainfo.xml e62211c2555ba23c768fefc363df89d361f364b7

>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 0f43ed5db69efa916f38c6bd576101f309fd8756

>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml cbf55e04f2ccee65446960094e23184a77d2a5e4

>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml 9a05b6f004a4c217ac4a6306af40fd054ff920ff

> 
> Diff: https://reviews.apache.org/r/30306/diff/
> 
> 
> Testing
> -------
> 
> Installed a 3-node cluster with only HDFS, ZK, and AMS. One of the hosts only had the
AMS component. When the install finishes, the other 2 hosts correctly had host_version records
in CURRENT, and the cluster_version was in CURRENT.
> After the install finishes, added a 4th node with all 3 components, and it correctly
created a host_version record in the CURRENT state.
> 
> This means that the UI needs to be robust enough to handle the case where some hosts
don't have host_version records.
> 
> Unit tests are in progress.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message