ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 30113: Ambari Server setup to install and copy JCE policy file in-place (handle both Default / Custom JDK scenarios)
Date Tue, 27 Jan 2015 19:02:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30113/#review69858
-----------------------------------------------------------

Ship it!



ambari-server/src/main/python/ambari_server/serverSetup.py
<https://reviews.apache.org/r/30113/#comment114672>

    Can you use shutil to copy the file?  This command isn't very portable.


- Nate Cole


On Jan. 27, 2015, 1:33 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30113/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 1:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9228
>     https://issues.apache.org/jira/browse/AMBARI-9228
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) During "ambari-server setup", if user chooses JDK option 1 or 2 (where ambari automatically
downloads JDK and JCE), setup should copy the JCE file to /resources and install the JCE on
the ambari server.
> 
> 2) Also need an "ambari-server setup-jce" command to put JCE zip in place on Ambari Server
and install on Ambari Server in cases where user chose option 3 custom jdk during setup.
> 
> {code}
> ambari-server setup-jce /path/to/downloaded/jce/policy/zip/file
> {code}
> 
> 1) user downloads JCE zip file
> 2) user runs "ambari-server setup-jce /tmp/UnlimitedJCEPolicyJDK7.zip" (for example)
> 3) setup-jce copies zip file into ambari-server /resources
> 4) setup-jce ambari.properties and set jce.name= to name of the zip file
> 5) setup-jce installs JCE on ambari-server
> 6) inform user to restart ambari-server
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server c034f5d 
>   ambari-server/src/main/python/ambari-server.py 60edab8 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 346f8a3 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 0fbc35c 
>   ambari-server/src/main/python/ambari_server/setupActions.py 90b9897 
>   ambari-server/src/test/python/TestAmbariServer.py 10596fe 
> 
> Diff: https://reviews.apache.org/r/30113/diff/
> 
> 
> Testing
> -------
> 
> Manual testing to see if JCE policy was automatically installed.
> 
> Added unit test in TestAmbariServer.py
> 
> # Jenkins test results
> 
> #test_install_jce_manualy (TestAmbariServer.TestAmbariServer) ... ok#
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 49:44 min
> [INFO] Finished at: 2015-01-21T06:35:03+00:00
> [INFO] Final Memory: 43M/450M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message