ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Baranchuk" <abaranc...@hortonworks.com>
Subject Re: Review Request 30174: Add SLIDER, KNOX service to Windows stack 2.2
Date Tue, 27 Jan 2015 00:56:02 GMT


> On Янв. 22, 2015, 8:07 п.п., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py,
line 37
> > <https://reviews.apache.org/r/30174/diff/1/?file=829935#file829935line37>
> >
> >     Do we need to add get_stack_to_component() for Windows?

we do not need to add it for win


> On Янв. 22, 2015, 8:07 п.п., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py,
line 40
> > <https://reviews.apache.org/r/30174/diff/1/?file=829935#file829935line40>
> >
> >     Again here the only thing we do differently is that we check if the service
has been installed. Long term this can be further refactored. Leave as is for now.

Leave as is for now.


> On Янв. 22, 2015, 8:07 п.п., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py,
line 26
> > <https://reviews.apache.org/r/30174/diff/1/?file=829940#file829940line26>
> >
> >     Fork at class level instead of function level.

there is only one function in class. easier to override method


> On Янв. 22, 2015, 8:07 п.п., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py,
line 26
> > <https://reviews.apache.org/r/30174/diff/1/?file=829945#file829945line26>
> >
> >     Fork at class level instead of service level.

there is only one function in class. easier to override method


> On Янв. 22, 2015, 8:07 п.п., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py,
line 24
> > <https://reviews.apache.org/r/30174/diff/1/?file=829946#file829946line24>
> >
> >     Again this is very repetitive. We should see if we can do away with forking.

big changes between linux and win. live is as it


> On Янв. 22, 2015, 8:07 п.п., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/metainfo.xml, line
18
> > <https://reviews.apache.org/r/30174/diff/1/?file=829955#file829955line18>
> >
> >     Might have to override slider-env config file
> >     
> >     See HDPWIN/2.1/services/HDFS/metainfo.xml as example.
> >     
> >     <metainfo>
> >       <schemaVersion>2.0</schemaVersion>
> >       <services>
> >         <service>
> >           <name>HDFS</name>
> >           <extends>common-services/HDFS/2.1.0.2.0</extends>
> >           <version>2.4.0.2.1.1.0</version>
> >     
> >           <components>
> >             <component>
> >               <name>HDFS_CLIENT</name>
> >               <configFiles>
> >                 <configFile>
> >                   <type>env</type>
> >                   <fileName>hadoop-env.cmd</fileName>
> >                   <dictionaryName>hadoop-env</dictionaryName>
> >                 </configFile>
> >               </configFiles>
> >             </component>
> >           </components>
> >         </service>
> >       </services>
> >     </metainfo>

works fine on win without overriding


> On Янв. 22, 2015, 8:07 п.п., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/SLIDER/metainfo.xml,
line 23
> > <https://reviews.apache.org/r/30174/diff/1/?file=829958#file829958line23>
> >
> >     Might have to override slider-env config file
> >     
> >     See HDPWIN/2.1/services/HDFS/metainfo.xml as example.
> >     
> >     <metainfo>
> >       <schemaVersion>2.0</schemaVersion>
> >       <services>
> >         <service>
> >           <name>HDFS</name>
> >           <extends>common-services/HDFS/2.1.0.2.0</extends>
> >           <version>2.4.0.2.1.1.0</version>
> >     
> >           <components>
> >             <component>
> >               <name>HDFS_CLIENT</name>
> >               <configFiles>
> >                 <configFile>
> >                   <type>env</type>
> >                   <fileName>hadoop-env.cmd</fileName>
> >                   <dictionaryName>hadoop-env</dictionaryName>
> >                 </configFile>
> >               </configFiles>
> >             </component>
> >           </components>
> >         </service>
> >       </services>
> >     </metainfo>

works fine on win without overriding


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30174/#review69229
-----------------------------------------------------------


On Янв. 22, 2015, 5:06 п.п., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30174/
> -----------------------------------------------------------
> 
> (Updated Янв. 22, 2015, 5:06 п.п.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-9270
>     https://issues.apache.org/jira/browse/AMBARI-9270
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add SLIDER, KNOX service to Windows stack 2.2
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
7d7d20c 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
8593c5a 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/ldap.py
2ff8297 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py
28fabe5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py
e05262f 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_mapping.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params.py
fbb1973 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_windows.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py
af085b8 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py
48c534e 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
2c99c54 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/gateway-log4j.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/gateway-site.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/knox-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ldap-log4j.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/topology.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/users-ldif.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/SLIDER/configurations/slider-client.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/SLIDER/configurations/slider-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/SLIDER/metainfo.xml PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/30174/diff/
> 
> 
> Testing
> -------
> 
> Unix tests passed
> Win cluster deployed success
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message