ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 30202: RU - Fix hardcoded Namenode address and JMX port
Date Mon, 26 Jan 2015 15:53:18 GMT


> On Jan. 23, 2015, 9:05 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py,
line 84
> > <https://reviews.apache.org/r/30202/diff/2/?file=831417#file831417line84>
> >
> >     This uses url2lib instead of curl; Alerts just got slammed with this when the
environment was kerberized. Without a proper keytab, the URL request would hit a 401 Unauthorized
error.
> >     
> >     Do we use this pattern a lot? I'd think it would fail all over the place.

I don't think you fixed this. url2lib won't work when requesting JMX resources in a kerberized
environment.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30202/#review69388
-----------------------------------------------------------


On Jan. 23, 2015, 7:57 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30202/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 7:57 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Yurii
Shylov.
> 
> 
> Bugs: AMBARI-9289
>     https://issues.apache.org/jira/browse/AMBARI-9289
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Java-side:
> UpgradeHelper hardcodes the JMX port number when figuring out the active and standby
namenodes.
> 
> Python-side:
> When using HA mode, the JMX URLs for NameNode must be taken from dfs.namenode.http-address.<cluster>.<nn#>
> See journalnode_upgrade.py
> E.g.,
> dfs.namenode.http-address.ha.nn1 : c6405.ambari.apache.org:50070
> dfs.namenode.http-address.ha.nn2 : c6403.ambari.apache.org:50070
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
f49e66675fbf1289cd7b797784f14bd8d631f1bf 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
ba5e804acea3a888036822aa2ec9789f536418d6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
746a04ace69a4d8b1c66215901d351f8a2395ef9 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java
239c79c7c1d5b4896a8ab1b90611caef0baced20 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 122e0a3b5e3de9084bd8282104c1642237ae5184

>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java e3d8619df3a6f0f579b8e592f0ac6bdf51be610f

>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java 38ac6435e0876c946101582856b5a4a6e19ef5dd

>   ambari-server/src/main/java/org/apache/ambari/server/utils/HostAndPort.java PRE-CREATION

>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py
4e85130d3538f0d76a093a7e0cbcdefec4f6088b 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_ha_state.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py
4d120b12d361a37177015cb1be894fef83462064 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
2634ce8fe1255d1d8a3b8a11ae1b6d17b2dc779e 
>   ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java e6cc089a1c3a465e87eabc2f1bd7832d62f9b0a7

>   ambari-server/src/test/java/org/apache/ambari/server/utils/TestHTTPUtils.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/30202/diff/
> 
> 
> Testing
> -------
> 
> Verified that both fixes worked in a 3-node HA cluster when performing a Rolling Upgrade.
> The first item is to allow the resolution of the active/standby namendoes to occur, which
is needed by Namenode Prepare and RESTART.
> The second item is for the Journalnode restart to query JMX correctly.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:14.455s
> [INFO] Finished at: Thu Jan 22 18:11:41 PST 2015
> [INFO] Final Memory: 50M/758M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message