ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Review Request 30258: Use cluster property rather than cluster-env/security_enabled to enable or disable Kerberos
Date Sun, 25 Jan 2015 19:42:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30258/
-----------------------------------------------------------

Review request for Ambari, Emil Anca, John Speidel, Robert Nettleton, and Tom Beerbower.


Bugs: AMBARI-8976
    https://issues.apache.org/jira/browse/AMBARI-8976


Repository: ambari


Description
-------

Use a cluster property rather than `cluster-env/security_enabled` to enable or disable Kerberos.
 Since `cluster-env/security_enabled` is used by services to determine if Kerberos is enabled
or not, it should not be set before completing the process of enabling or disabling Kerberos.
 To declare whether the cluster enable or disable Kerberos, a property on the cluster should
be set.  The property should be called `security_type` and must have one of the following
values:
* NONE
* KERBEROS 

By using `cluster-env/security_enabled`, the configuration property gets set to "true" before
Kerberos is filly enabled.   This is causing issues with stopping services so that the updated
Kerberos-related configurations can be set.

Example API call to enable Kerberos
```
PUT /api/v1/clusters/c1
{
  "Clusters" : {
    "security_type" : "KERBEROS"
  }
}
```

Example API call to disable Kerberos
```
PUT /api/v1/clusters/c1
{
  "Clusters" : {
    "security_type" : "NONE"
  }
}
```


Diffs
-----

  ambari-server/docs/api/v1/clusters-cluster.md 0c84c43 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
106c1dd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java 8d2cce1

  ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java 2c233e6

  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 6620577

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
c54a8c4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
e11accb 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 889a775

  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b344a05 
  ambari-server/src/main/java/org/apache/ambari/server/state/SecurityType.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 220a5af

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
16273e0 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 783f7a2

  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 21ba270 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql cab6dfa 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 81f6c50 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql fe1eef7 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1359fc1 
  ambari-server/src/main/resources/properties.json 45c7e06 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
6f2699b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
b5bc4d0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
f6c34f2 
  ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java
a0e358a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterRequestTest.java
3e2fbba 
  ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterResponseTest.java
050b80a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
c6c9574 
  ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java
02e5277 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
2187145 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
d54a7d6 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
e7e1358 

Diff: https://reviews.apache.org/r/30258/diff/


Testing
-------

Manually tested in test cluster
Updated unit tests

#Jenkins test results

Running org.apache.ambari.server.controller.KerberosHelperTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.768 sec

Running org.apache.ambari.server.controller.AmbariManagementControllerImplTest
Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.73 sec

Ambari server test results
Tests run: 2598, Failures: 0, Errors: 0, Skipped: 15

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 59:58 min
[INFO] Finished at: 2015-01-25T19:31:28+00:00
[INFO] Final Memory: 44M/542M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message