ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Review Request 30222: Views: NPE on getProperties
Date Fri, 23 Jan 2015 18:50:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30222/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-9307
    https://issues.apache.org/jira/browse/AMBARI-9307


Repository: ambari


Description
-------

There is an issue in the view context implementation that it passes nulls along to Velocity
for template parameterization. It results in the following ...

    java.lang.NullPointerException
	    at java.io.StringReader.<init>(StringReader.java:50)
    	at org.apache.velocity.runtime.RuntimeInstance.evaluate(RuntimeInstance.java:1265)
	    at org.apache.velocity.app.Velocity.evaluate(Velocity.java:180)
	    at org.apache.ambari.server.view.ViewContextImpl.parameterize(ViewContextImpl.java:409)
	    at org.apache.ambari.server.view.ViewContextImpl.getProperties(ViewContextImpl.java:194)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 438ee75 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java 94d5458


Diff: https://reviews.apache.org/r/30222/diff/


Testing
-------

Manual testing with Slider view.
Updated existing unit tests for null property case.

All existing tests pass ...

Results :

Tests run: 2595, Failures: 0, Errors: 0, Skipped: 15


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message