ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 30164: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(URL-encoding)
Date Thu, 22 Jan 2015 16:27:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30164/
-----------------------------------------------------------

(Updated Янв. 22, 2015, 4:27 п.п.)


Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower.


Changes
-------

renamed and added comments for the private method


Bugs: AMBARI-8605
    https://issues.apache.org/jira/browse/AMBARI-8605


Repository: ambari


Description
-------

Stacks endpoint returns java exception for query predicate which use .matches and logical
OR, for example:
/api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=&StackConfigurations/property_type.matches((.USER.)|(.GROUP.*))

/api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=&(StackConfigurations/property_type.matches(.USER.)|StackConfigurations/property_type.matches(.GROUP.*))

Regexp grouping with () doesn't work


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
3238312 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
8be5112 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java
421d533 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/Precision.java
PRE-CREATION 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricAggregator.java
f4f895f 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregator.java
e291f36 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregatorHourly.java
1d5c5a4 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
5224450 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
c9d56fc 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
2ca7669 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITClusterAggregator.java
2da9c82 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITMetricAggregator.java
22e1363 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
PRE-CREATION 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricTestHelper.java
PRE-CREATION 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java
0722ccd 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java
333b13b 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
c893314 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestTimelineWebServices.java
2b93190 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
bf68986 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
e9aac45 

Diff: https://reviews.apache.org/r/30164/diff/


Testing
-------

[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [3.287s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.436s]
[INFO] Ambari Web ........................................ SUCCESS [42.942s]
[INFO] Ambari Views ...................................... SUCCESS [2.247s]
[INFO] Ambari Admin View ................................. SUCCESS [10.312s]
[INFO] Ambari Server ..................................... SUCCESS [31:07.912s]
[INFO] Ambari Agent ...................................... SUCCESS [6.565s]
[INFO] Ambari Client ..................................... SUCCESS [0.042s]
[INFO] Ambari Python Client .............................. SUCCESS [0.558s]
[INFO] Ambari Groovy Client .............................. SUCCESS [10.233s]
[INFO] Ambari Shell ...................................... SUCCESS [0.032s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [6.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message