ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)
Date Thu, 22 Jan 2015 13:05:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28851/
-----------------------------------------------------------

(Updated Янв. 22, 2015, 1:05 п.п.)


Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower.


Changes
-------

Uploading hare only lexer changes. For URL-encoding changes separated review board will be
created.


Summary (updated)
-----------------

Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)


Bugs: AMBARI-8605
    https://issues.apache.org/jira/browse/AMBARI-8605


Repository: ambari


Description
-------

Stacks endpoint returns java exception for query predicate which use .matches and logical
OR, for example:
/api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&StackConfigurations/property_type.matches((.*USER.*)|(.*GROUP.*))

/api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&(StackConfigurations/property_type.matches(.*USER.*)|StackConfigurations/property_type.matches(.*GROUP.*))

Regexp grouping with () doesn't work


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java b645040

  ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java 2c04d6c


Diff: https://reviews.apache.org/r/28851/diff/


Testing
-------

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [3.287s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.436s]
[INFO] Ambari Web ........................................ SUCCESS [42.942s]
[INFO] Ambari Views ...................................... SUCCESS [2.247s]
[INFO] Ambari Admin View ................................. SUCCESS [10.312s]
[INFO] Ambari Server ..................................... SUCCESS [31:07.912s]
[INFO] Ambari Agent ...................................... SUCCESS [6.565s]
[INFO] Ambari Client ..................................... SUCCESS [0.042s]
[INFO] Ambari Python Client .............................. SUCCESS [0.558s]
[INFO] Ambari Groovy Client .............................. SUCCESS [10.233s]
[INFO] Ambari Shell ...................................... SUCCESS [0.032s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [6.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message