ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 30138: LDAP Group sync truncates whitespace in group name
Date Thu, 22 Jan 2015 11:10:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30138/
-----------------------------------------------------------

(Updated Jan. 22, 2015, 11:10 a.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-9250
    https://issues.apache.org/jira/browse/AMBARI-9250


Repository: ambari


Description
-------

Group sync fails with groups whose names have white space such as 'Unix Systems Engineers'
due to the white space being removed.


    ambari-server sync-ldap --groups=groups.txt


groups.txt:
    Unix Systems Engineers


    09:08:06,460 ERROR [pool-2-thread-9] LdapSyncEventResourceProvider:425 - Caught exception
running LDAP sync. 
    org.apache.ambari.server.AmbariException: Couldn't sync LDAP group UnixSystemsEngineers,
it doesn't exist
	    at org.apache.ambari.server.security.ldap.AmbariLdapDataPopulator.synchronizeLdapGroups(AmbariLdapDataPopulator.java:238)


Diffs
-----

  ambari-server/src/main/python/ambari-server.py b75611f 
  ambari-server/src/test/python/TestAmbariServer.py e0b390c 

Diff: https://reviews.apache.org/r/30138/diff/


Testing
-------

New unit tests added.

Manual test to verify that spaces in names are not stripped.

All existing tests pass ...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:04 min
[INFO] Finished at: 2015-01-21T14:56:49-05:00
[INFO] Final Memory: 42M/629M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message