ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 30133: API does not allow Repo URL to be changed if the repo version is current
Date Thu, 22 Jan 2015 10:26:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30133/#review69152
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Jan. 21, 2015, 6:27 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30133/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9242
>     https://issues.apache.org/jira/browse/AMBARI-9242
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> API disallows Repo URLs from being edited if the version is current.
> We allow this in 1.7.0 and is a regression.
> We'll not be able to accommodate the case if the repo URL changes (say one local mirror
server to another, or from public URL to local mirror, etc).
> 
> It is allowed always to change display_name.
> It is possible to change upgrade_pack if it is not installed on any of the clusters.
> It is possible to always change base URLs.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
a463439 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
17fa2c2 
> 
> Diff: https://reviews.apache.org/r/30133/diff/
> 
> 
> Testing
> -------
> 
> In progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message