ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Review Request 30147: JAAS configuration file parser leaves trailing quote in quoted values
Date Wed, 21 Jan 2015 23:28:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30147/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Jaimin Jetly.


Bugs: AMBARI-9244
    https://issues.apache.org/jira/browse/AMBARI-9244


Repository: ambari


Description
-------

The JAAS configuration file parser used in determining the security state of some components
(like ZooKeeper and HBase) leaves trailing quote in quoted values. 

For example:

```
Client {
com.sun.security.auth.module.Krb5LoginModule required
useKeyTab=true
storeKey=true
useTicketCache=false
keyTab="/etc/security/keytabs/hbase.service.keytab"
principal="hbase/vp-ambari-ranger-med-0120-2.cs1cloud.internal@EXAMPLE.COM";
};
```
The value for `keytab` is being parsed as `/etc/security/keytabs/hbase.service.keytab"` rather
than `/etc/security/keytabs/hbase.service.keytab`.


Diffs
-----

  ambari-agent/src/test/python/resource_management/TestSecurityCommons.py 196ae34 
  ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
7f6ed00 

Diff: https://reviews.apache.org/r/30147/diff/


Testing
-------

Manually tested in a test cluster
Updated `security_commons.py` on agent node exhibiting the issue - this fixed one of potenally
a few issues related to Kerberized components.

Added unit test to resource_management.TestSecurityCommons.TestSecurityCommons

**NOTE: Tests still running in Jenkins**


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message