ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 30136: Fix post-install hook for hdp-select
Date Wed, 21 Jan 2015 21:16:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 9:16 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.


Changes
-------

Added file removal during host cleanup. Verified manually + unit test


Bugs: AMBARI-9248
    https://issues.apache.org/jira/browse/AMBARI-9248


Repository: ambari


Description
-------

There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current
version to the latest installed


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
  ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
dd18e8d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 6620577

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStageContainer.java
49ba946 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/kerberos.json 6ab7610

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
f256688 
  ambari-server/src/main/resources/stacks/HDP/2.2/kerberos.json 46aff38 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
6f2699b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java
a0e358a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
c6c9574 
  ambari-web/app/assets/test/tests.js 827ccb8 
  ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js
29c8306 
  ambari-web/app/controllers/main/host/details.js 40077f7 
  ambari-web/app/models/service_config.js 047c1b2 
  ambari-web/app/templates/main/admin/highAvailability/resourceManager/step3.hbs c143eef 
  ambari-web/app/utils/config.js 6eaad57 
  ambari-web/test/controllers/main/admin/highAvailability/resourceManager/step3_controller_test.js
155bc67 
  ambari-web/test/controllers/main/host/details_test.js 41b32ad 
  ambari-web/test/models/service_config_test.js afdd663 

Diff: https://reviews.apache.org/r/30136/diff/


Testing
-------

Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment
to see all effects

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.865s]
[INFO] Ambari Server ..................................... SUCCESS [35.053s]
[INFO] Ambari Agent ...................................... SUCCESS [6.128s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44.924s
[INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
[INFO] Final Memory: 41M/353M


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message