ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 30113: Ambari Server setup to install and copy JCE policy file in-place (handle both Default / Custom JDK scenarios)
Date Wed, 21 Jan 2015 20:25:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30113/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 3:25 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.


Changes
-------

Removed `return 0`s


Bugs: AMBARI-9228
    https://issues.apache.org/jira/browse/AMBARI-9228


Repository: ambari


Description
-------

1) During "ambari-server setup", if user chooses JDK option 1 or 2 (where ambari automatically
downloads JDK and JCE), setup should copy the JCE file to /resources and install the JCE on
the ambari server.

2) Also need an "ambari-server setup-jce" command to put JCE zip in place on Ambari Server
and install on Ambari Server in cases where user chose option 3 custom jdk during setup.

{code}
ambari-server setup-jce /path/to/downloaded/jce/policy/zip/file
{code}

1) user downloads JCE zip file
2) user runs "ambari-server setup-jce /tmp/UnlimitedJCEPolicyJDK7.zip" (for example)
3) setup-jce copies zip file into ambari-server /resources
4) setup-jce ambari.properties and set jce.name= to name of the zip file
5) setup-jce installs JCE on ambari-server
6) inform user to restart ambari-server


Diffs (updated)
-----

  ambari-server/sbin/ambari-server c034f5d 
  ambari-server/src/main/python/ambari-server.py 7c08083 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 44c30ce 
  ambari-server/src/test/python/TestAmbariServer.py 408c088 

Diff: https://reviews.apache.org/r/30113/diff/


Testing
-------

Manual testing to see if JCE policy was automatically installed.

Added unit test in TestAmbariServer.py

# Jenkins test results

#test_install_jce_manualy (TestAmbariServer.TestAmbariServer) ... ok#

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 49:44 min
[INFO] Finished at: 2015-01-21T06:35:03+00:00
[INFO] Final Memory: 43M/450M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message