ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 30132: Artifact resource doesn't properly preserve nested map structures for artifact data
Date Wed, 21 Jan 2015 20:19:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30132/#review68994
-----------------------------------------------------------

Ship it!


Looks good. Just a small issue I noticed below.


ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestBody.java
<https://reviews.apache.org/r/30132/#comment113569>

    Minor issue:
    
    Shouldn't "RAW_REQUEST_BODY" be replaced with the constant defined in the Request class
in this patch?


- Robert Nettleton


On Jan. 21, 2015, 6:28 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30132/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 6:28 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9243
>     https://issues.apache.org/jira/browse/AMBARI-9243
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When an artifact resource is created with a nested map structure, the json representation
of the resource flattens out the property names instead of preserving the original hierarchy.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestBody.java
f4c5647 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
b3eb159 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java f937a4c

>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ArtifactResourceProviderTest.java
4ed1a51 
> 
> Diff: https://reviews.apache.org/r/30132/diff/
> 
> 
> Testing
> -------
> 
> Functional tests using nexted artifact data.
> Unit Tests:
> All existing pass.
> Added new unit tests for this scenario.
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message