ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 30077: Upgrades: Make a ResourceDefinition for UpgradeResourceProvider for downgrade directive
Date Tue, 20 Jan 2015 16:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30077/#review68730
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/30077/#comment113112>

    I'm not sure this is what should be happening.  I think the directive may be to prevent
the "full service check" from happening (3 times this gets scheduled).  This code will stop
all service checks from happening.  Let's confirm with Yusaku since he was requesting it.


- Nate Cole


On Jan. 20, 2015, 10:41 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30077/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 10:41 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-9214
>     https://issues.apache.org/jira/browse/AMBARI-9214
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add an Upgrade ResourceDefinition so that we can use these directives:
> 
> downgrade:  boolean that makes the upgrade a downgrade 
> skip_service_checks: boolean that disables the upcoming service-check-all after core
components
> 
> 
> Also cleaned up a sloppy cut and paste job in ClientConfigResourceDefinition.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
1cd7e17 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClientConfigResourceDefinition.java
4ff37ac 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
fc28c13 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
92ecd1e 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
d9c9aec 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
73aa828 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
d264511 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinitionTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
cd5f23e 
> 
> Diff: https://reviews.apache.org/r/30077/diff/
> 
> 
> Testing
> -------
> 
> Unit tests added.  All existing tests pass.
> 
> Manual tests in progress...
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message