ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Barca" <fba...@hortonworks.com>
Subject Re: Review Request 29983: Refactor the OS-dependent Ambari Server Windows components - Part 1.4
Date Tue, 20 Jan 2015 00:04:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29983/
-----------------------------------------------------------

(Updated Jan. 20, 2015, 12:04 a.m.)


Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya,
Mahadev Konar, and Nate Cole.


Bugs: AMBARI-8317
    https://issues.apache.org/jira/browse/AMBARI-8317


Repository: ambari


Description
-------

+Further decomposing ambari-server.py: Moved setup, reset and upgrade into their own files
+Made them OS-independent - now the same routines are being used in Windows too (save upgrade,
which is not active in Windows yet)
+Merged the OS-dependent code for JDBC & JDK setup, database interface creation, firewall
checks
+Refactored the database setup: split the supported DBMSes into distinct objects
+Replaced recursive calls in the user input routines


Diffs (updated)
-----

  ambari-common/src/main/python/ambari_commons/firewall.py 76d9890a8edc2902c1f2c145626b6b6e41836573

  ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa

  ambari-common/src/main/python/ambari_commons/logging_utils.py af1390cc4643d3b2e80f0cdf3697babcc48eb23a

  ambari-server/conf/unix/ambari.properties e29a6e25f576a8f806a447a4cf03c56f4d0c105b 
  ambari-server/conf/windows/ambari.properties d5c531319e52da10b599fd771d63ca6eee88a39f 
  ambari-server/src/main/python/ambari-server-windows.py 923110546517c1962cfd7c9b20fdd4f0721ff907

  ambari-server/src/main/python/ambari-server.py 7c080834f0cf3b2e7ec15a9fbf3f955938f7b5be

  ambari-server/src/main/python/ambari_server/dbConfiguration.py a2008794522fb18fbef745433dfb3aaa63f6368f

  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 62853b72787c14be8717e786f6f43c391c8901c8

  ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py ab038db82c8467e877f6822b3401bc6688149114

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 44c30ceb568d4361812063af17741d83666a7a61

  ambari-server/src/main/python/ambari_server/serverSetup.py 7d4544595396ecbe9bdb663deea124d7842bbacd

  ambari-server/src/main/python/ambari_server/serverSetup_linux.py 33241515f6648f8a066f090ec6a98493008ff092

  ambari-server/src/main/python/ambari_server/serverSetup_windows.py dce404d50b98bd4330da8891d9eb0b2e61a76cf7

  ambari-server/src/main/python/ambari_server/serverUpgrade.py PRE-CREATION 
  ambari-server/src/main/python/ambari_server/setupActions.py ee8eaa07fee924ec46a6edc828ea9dc4686fbdc5

  ambari-server/src/main/python/ambari_server/setupSecurity.py 34070391046a0aee680f735a6f3e0e23ba8a7d16

  ambari-server/src/main/python/ambari_server/userInput.py 3e8b2c74b28212b3fcc552d1697087f8101f6c74

  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99

  ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-ANY/scripts/setup_jdk.py
d48bb523e9ff4d8c81d42fed25d0043e75a0e3cb 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/package/scripts/mapred_service_check.py
f81408f546a90e07ed3a1434b7d6e8f62fa62966 
  ambari-server/src/test/python/TestAmbariServer.py 408c0889759fa24c518283dd3c5a26c5fc173705


Diff: https://reviews.apache.org/r/29983/diff/


Testing
-------

mvn clean test

ambari-server setup (--silent, --verbose) ->start -> ui ok
ambari-server reset ->start -> ui ok
ambari-server upgrade ->start -> ui ok


Thanks,

Florian Barca


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message