ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 30009: Test principal and keytab required for service check should be created as part of kerberos service check action
Date Mon, 19 Jan 2015 16:13:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30009/#review68618
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On Jan. 18, 2015, 3:30 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30009/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2015, 3:30 a.m.)
> 
> 
> Review request for Ambari, John Speidel, Robert Nettleton, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9149
>     https://issues.apache.org/jira/browse/AMBARI-9149
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Intercept call to execute SERVICE_CHECK for KERBEROS service and (if necessary) create
and distribute test user keytab.
> 
> It will be hard coded that the test user information is taken from the "smokeuser" identity
in the relevant clusters Kerberos descriptor.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
6dabcbb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
6d0e159 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStageContainer.java
12b7f71 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/kerberos.json PRE-CREATION

>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
5e933d2 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java
2b00f40 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
8900a26 
> 
> Diff: https://reviews.apache.org/r/30009/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in test cluster
> Updated unit tests
> 
> # Jenkins Test Results
> Running org.apache.ambari.server.controller.AmbariCustomCommandExecutionHelperTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.301 sec
> 
> Running org.apache.ambari.server.controller.KerberosHelperTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.751 sec
> 
> Results for ambari-server tests
> Tests run: 2551, Failures: 0, Errors: 0, Skipped: 15
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message