ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 29956: Enable Running All Service Smoke Tests at various check points in upgrade pack
Date Mon, 19 Jan 2015 15:00:22 GMT


> On Jan. 19, 2015, 8:55 a.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line
196
> > <https://reviews.apache.org/r/29956/diff/4/?file=824381#file824381line196>
> >
> >     Just a thought ... instead of these instance checks could we have a method on
Grouping that gets overridden by ClusterGrouping and ServiceCheckGrouping?

Was considering that, but was trying to avoid groupings having to know too much about clusters.
 I'll make a JIRA for that.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/#review68600
-----------------------------------------------------------


On Jan. 17, 2015, 8:52 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29956/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 8:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9167
>     https://issues.apache.org/jira/browse/AMBARI-9167
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enable full smoke tests.  Involved changes to the upgrade pack:
> 
> Each group runs it's own service check.  Need to be able to turn them off such that the
next group (a service-check one) that runs full checks doesn't re-run ones it just did.  For
example.  Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT.  No
need to run service checks on CORE_MASTER when running them all right after anyway.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 1662baa

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
1b957da 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
b4a75ae 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 325df21 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
26e1546 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93

>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
cf191d5 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29956/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.403s
> [INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
> [INFO] Final Memory: 31M/337M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message