ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yurii Shylov" <yurii.shy...@gmail.com>
Subject Re: Review Request 29969: Rollling Upgrade - Server bootstrap creates incorrect repo version
Date Sat, 17 Jan 2015 01:00:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29969/
-----------------------------------------------------------

(Updated Янв. 17, 2015, 1 д.п.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.


Changes
-------

On clean install cluster version is now having UPGRADING state till install is finished; second
cluster version won't be created in case of wrong version in heartbit, exception will be thrown
instead; added version check for state transfer


Bugs: AMBARI-9183
    https://issues.apache.org/jira/browse/AMBARI-9183


Repository: ambari


Description
-------

Currently on clean install Ambari creates cluster entity and its repository version with version
taken from selected stack. I.e. for stack HDP-2.2, version 2.2 is written to database, without
any information about the actual minor version of that stack. Besides that we can't assume
that cluster has some version until it has at least one of components of that version.
Repository version creation should be detached from cluster creation; instead of that versions
should be created after receiving the first actual version from service responses during install.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java b5fda49

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
6dabcbb 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
befd014 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java ed9fa24

  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java fd0188c 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 19a5f9f

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 9ec8c36

  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
31606ca 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 57c0223


Diff: https://reviews.apache.org/r/29969/diff/


Testing
-------

In progress

Manual testing was performed on 3-node cluster


Thanks,

Yurii Shylov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message