ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 29968: Request to start Downgrade failed
Date Fri, 16 Jan 2015 18:37:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29968/#review68447
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/29968/#comment112680>

    minor :
    
    I think this could just be ...
    
        boolean forDowngrade = Boolean.valueOf(forceDowngrade);
        
    ... which accounts for null.


- Tom Beerbower


On Jan. 16, 2015, 6:29 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29968/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 6:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9182
>     https://issues.apache.org/jira/browse/AMBARI-9182
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing a downgrade, need to be able to specify ALSO the version that was used
to attempt a downgrade.  When specified, that indicates the version to lookup the upgrade
pack and apply a downgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
9b17b33 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
bd06c5f 
> 
> Diff: https://reviews.apache.org/r/29968/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.155s
> [INFO] Finished at: Fri Jan 16 13:28:39 EST 2015
> [INFO] Final Memory: 31M/341M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message