ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Review Request 29967: Move existing (user) custom actions to a new location
Date Fri, 16 Jan 2015 16:27:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29967/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-9180
    https://issues.apache.org/jira/browse/AMBARI-9180


Repository: ambari


Description
-------

We moved all custom action scripts to a 'scripts' subdir. This is required to provide ability
to invoke templates via our resource management framework.
On upgrade of existing 1.7.0 ambari-server, we have to move custom action scripts that have
been added by user to a new location


Diffs
-----

  ambari-server/src/main/python/ambari-server.py ba3d5e7 
  ambari-server/src/test/python/TestAmbariServer.py a8f4197 

Diff: https://reviews.apache.org/r/29967/diff/


Testing
-------

Unit tests pass except unrelated test that is failing on trunk


======================================================================
FAIL: test_prompt_db_properties_for_each_database_type (TestAmbariServer.TestAmbariServer)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/plextor/review_ambari/ambari-common/src/test/python/mock/mock.py", line 1199,
in patched
    return func(*args, **keywargs)
  File "/media/plextor/review_ambari/ambari-server/src/test/python/TestAmbariServer.py", line
2370, in test_prompt_db_properties_for_each_database_type
    self.assertFalse(_ambari_server_.JDBC_POSTGRES_SCHEMA_PROPERTY in properties.propertyNames())
AssertionError: True is not false

----------------------------------------------------------------------
Ran 235 tests in 3.212s

FAILED (failures=1)
----------------------------------------------------------------------
Failed tests:
FAIL: test_prompt_db_properties_for_each_database_type (TestAmbariServer.TestAmbariServer)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/plextor/review_ambari/ambari-common/src/test/python/mock/mock.py", line 1199,
in patched
    return func(*args, **keywargs)
  File "/media/plextor/review_ambari/ambari-server/src/test/python/TestAmbariServer.py", line
2370, in test_prompt_db_properties_for_each_database_type
    self.assertFalse(_ambari_server_.JDBC_POSTGRES_SCHEMA_PROPERTY in properties.propertyNames())
AssertionError: True is not false

----------------------------------------------------------------------
Total run:585
Total errors:0
Total failures:1


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message