ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29957: RU - ZK Client needs to advertise version for Finalize to work
Date Fri, 16 Jan 2015 16:21:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29957/
-----------------------------------------------------------

(Updated Jan. 16, 2015, 4:21 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-9168
    https://issues.apache.org/jira/browse/AMBARI-9168


Repository: ambari


Description
-------

The Cluster Finalize action needs all components to advertise the version.
Right now, ZK Client is not restarted when the ZK Group is done.
ZK Client will need to call hdp-select set zookeeper-client {version}

Also, ZKFC needs to either be ignored or advertise a version.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
28a47216f951ce63e107c5c8b5f468af25e36e0e 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py
d8455e836ee75a9b0120a8ee0f9f4e585c44d9ee 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
81d360447f26f13cb4c6e4d7a4f6035751b88ec1 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5cf68d62cf25ddc8d125102eb5b812d9f8


Diff: https://reviews.apache.org/r/29957/diff/


Testing (updated)
-------

Copied the changed files to a cluster before the upgraded, and ZK Client correctly advertised
its version.
The Finalize step completed successfuly.

ambari=> select task_id, role, status, role_command, structured_out from host_role_command
where host_name LIKE '%c6408%' and role = 'ZOOKEEPER_CLIENT' ORDER BY task_id ASC;
 task_id |       role       |  status   |  role_command  |       structured_out
---------+------------------+-----------+----------------+-----------------------------
       8 | ZOOKEEPER_CLIENT | COMPLETED | INSTALL        | {"version": "2.2.0.0-2041"}
      74 | ZOOKEEPER_CLIENT | COMPLETED | INSTALL        | {"version": "2.2.0.0-2041"}
     107 | ZOOKEEPER_CLIENT | COMPLETED | CUSTOM_COMMAND | {"version": "2.2.1.0-2205"}
(3 rows)

ambari=> select * from hostcomponentstate where component_name = 'ZOOKEEPER_CLIENT';
 cluster_id |  component_name  |   version    |          current_stack_version           |
current_state |        host_name        | service_name | upgrade_state | security_state
------------+------------------+--------------+------------------------------------------+---------------+-------------------------+--------------+---------------+----------------
          2 | ZOOKEEPER_CLIENT | 2.2.1.0-2205 | {"stackName":"HDP","stackVersion":"2.2"} |
INSTALLED     | c6408.ambari.apache.org | ZOOKEEPER    | COMPLETE      | UNKNOWN
(1 row)

Unit tests passed
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:47.274s
[INFO] Finished at: Fri Jan 16 08:12:22 PST 2015
[INFO] Final Memory: 63M/545M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message