ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako" <yus...@hortonworks.com>
Subject Re: Review Request 29951: RU repo version pattern adjustment
Date Thu, 15 Jan 2015 23:18:32 GMT


> On Jan. 15, 2015, 11:12 p.m., Alejandro Fernandez wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js,
line 23
> > <https://reviews.apache.org/r/29951/diff/1/?file=823179#file823179line23>
> >
> >     I believe this should be
> >     ^(\d+.)*\d+(-\d+)?$
> >     
> >     Try this pattern on regexpal.com
> >     ^(\d+.)*\d+(-\d+)? (pass)?(fail)?$
> >     
> >     With this text:
> >     1 pass
> >     1. fail
> >     1- fail
> >     1-1 pass
> >     1.-1 fail
> >     1.2 pass
> >     1.2-1 pass
> >     1.2- fail
> >     1.2.3 pass
> >     1.2.3- fail
> >     1.2.3. fail
> >     1.2.3-1 pass
> >     1.2.3-1234 pass
> >     1.2.3-12. fail
> >     1.2.3.1234 pass

This is the pattern for what comes after the stack-major.minor. (e.g., "HDP-2.2."), so that's
not correct.


- Yusaku


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29951/#review68347
-----------------------------------------------------------


On Jan. 15, 2015, 11:01 p.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29951/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 11:01 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9164
>     https://issues.apache.org/jira/browse/AMBARI-9164
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adjust regex.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
bdfb755 
>   ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js
abae72a 
> 
> Diff: https://reviews.apache.org/r/29951/diff/
> 
> 
> Testing
> -------
> 
> All unit test passed. New unit test provided.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message