ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Review Request 29939: Allow a set of property names to ignore to be passed into the predicate compiler
Date Thu, 15 Jan 2015 18:39:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29939/
-----------------------------------------------------------

Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.


Bugs: AMBARI-9153
    https://issues.apache.org/jira/browse/AMBARI-9153


Repository: ambari


Description
-------

The introduction of request directives to the query string requires that the request can tell
the predicate compiler to ignore these directives.
This patch introduces an overloaded compile method of PredicateCompiler which allows the caller
to pass in a set of property names to ignore.
These ignored properties, will be discared by the lexer and will not be parsed into a predicate.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/predicate/PredicateCompiler.java
7738d2c 
  ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java 3940c34

  ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java a587480


Diff: https://reviews.apache.org/r/29939/diff/


Testing
-------

Added new unit test.
All unit tests pass.


Thanks,

John Speidel


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message