ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 29917: Create new API endpoints for cluster and service kerberos descriptors
Date Thu, 15 Jan 2015 15:27:25 GMT


> On Jan. 15, 2015, 2:06 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java,
lines 188-196
> > <https://reviews.apache.org/r/29917/diff/1/?file=822389#file822389line188>
> >
> >     We probably should start writing the @GET methods without the String body parameter.
 I think that they are the cause of all of these startup warnings in the logs ...
> >     
> >         WARNING: A HTTP GET method, public javax.ws.rs.core.Response org.apache.ambari.server.api.services.StacksService.getStack(java.lang.String,javax.ws.rs.core.HttpHeaders,javax.ws.rs.core.UriInfo,java.lang.String),
should not consume any entity.

I though about it but I know that the UI sometimes passes the query string in the body request
info and I didn't want to prevent them from doing so.


> On Jan. 15, 2015, 2:06 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java,
lines 457-462
> > <https://reviews.apache.org/r/29917/diff/1/?file=822391#file822391line457>
> >
> >     Does this mean that you see TypeRegistration and dynamic sub-resources used
by other resource types?  If so, why not just make it a common class now?

Since the registrations were statically defined in the provider and nobody else was using
it I left it here.  There is still a bit more work to be done to get dynamic registration
of the resource to work and I was going to move it out at that point.  So the short answer
is that the interface isn't really useful at this time but will be in the future.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29917/#review68244
-----------------------------------------------------------


On Jan. 15, 2015, 3:44 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29917/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 3:44 a.m.)
> 
> 
> Review request for Ambari, Robert Levas and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9142
>     https://issues.apache.org/jira/browse/AMBARI-9142
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add new cluster and service artifact endpoints.
> These new artifact endpoints can be used to expose kerberos descriptors for clusters
and services.
> 
> New cluster artifact endpoint: clusters/c1/artifacts
> New service artifact endpoint: clusters/c1/services/s1/artifacts
> 
> For more detailed information see the associated Jira.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
422cf1c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
a75729d 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java
be8e0b4 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
ead49ca 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
a51b50b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
be2a9ad 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 740f37e

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ArtifactDAO.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ArtifactEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ArtifactEntityPK.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
dae920e 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4e61f36 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 59031f7 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql bfb49e5 
>   ambari-server/src/main/resources/META-INF/persistence.xml dc49b7c 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java
6d897b2 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
b5cfcc3 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ServiceResourceDefinitionTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ArtifactResourceProviderTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
73531ec 
> 
> Diff: https://reviews.apache.org/r/29917/diff/
> 
> 
> Testing
> -------
> 
> Manual functional testing including creating and obtaining cluster and service artifacts.
> New Unit tests added.
> 
> Currently running unit tests on patch.
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message