ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 29864: Views: validation for properties is ignored in PUT requests
Date Wed, 14 Jan 2015 13:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29864/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 1:45 p.m.)


Review request for Ambari and Nate Cole.


Changes
-------

Update diff.  Change transactional scope.


Bugs: AMBARI-9112
    https://issues.apache.org/jira/browse/AMBARI-9112


Repository: ambari


Description
-------

An invalid property supplied for an update is rejected by the validator but the view registry
local copy of the view instance entity is updated with the bogus value.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
12a8bee 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java dd7417a 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 57a05f1 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 26a9b36


Diff: https://reviews.apache.org/r/29864/diff/


Testing
-------

Manual tests. New unit tests added. All tests pass ...

Results :

Tests run: 2507, Failures: 0, Errors: 0, Skipped: 13

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:03 min
[INFO] Finished at: 2015-01-13T15:22:29-05:00
[INFO] Final Memory: 42M/527M
[INFO] ------------------------------------------------------------------------
[INFO] Final Memory: 42M/601M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message