ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 29858: Manual Upgrade Tasks Should Be More Explicit And Parameterized
Date Tue, 13 Jan 2015 20:59:51 GMT


> On Jan. 13, 2015, 2:44 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, lines
300-301
> > <https://reviews.apache.org/r/29858/diff/1/?file=819657#file819657line300>
> >
> >     Maybe in the future we can keep the HostsType object with the StageWrapper,
as the call to mhr.getMasterAndHosts() is expensive.

We're lucky in that the manual tasks don't occur for services/components that are expensive
:) Maybe we should pre-calculate this ahead of time and store it? Thoughts?


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29858/#review67921
-----------------------------------------------------------


On Jan. 13, 2015, 2:39 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29858/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-9109
>     https://issues.apache.org/jira/browse/AMBARI-9109
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For Hive upgrade, the following manual step was shown:
> {noformat}
> Run the SQL file at /usr/hdp/$version/hive/scripts/metastore/upgrade to update the Hive
Metastore schema.
> {noformat}
> 
> This is too vague.  I could not figure out what to do.
> 1. It should tell the user exactly which host this needs to be done on.
> 2. $version should be substituted with the actual directory name.
> 3. There are 40+ SQL files in the aforementioned "upgrade" folder.  What's the exact
command that I need to run?
> 
> All services that use Manual Tasks as part of the upgrade should be revisited once the
parameterization code is completed to ensure that the messages are correct. These include:
Hive, Falcon, Oozie, HDFS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java
4df0f9c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java
46d0dd4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
b8d8502 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java
b453362 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 5882e3e

>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java ac30762

>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml c110a0b 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 53505f2

>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml
b777d94 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml aee1fcf

> 
> Diff: https://reviews.apache.org/r/29858/diff/
> 
> 
> Testing
> -------
> 
> New tests written
> 
> Tests run: 2526, Failures: 0, Errors: 0, Skipped: 15
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message