ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 29789: Add principal type to Kerberos descriptor
Date Tue, 13 Jan 2015 16:00:56 GMT


> On Jan. 12, 2015, 3:15 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java,
line 167
> > <https://reviews.apache.org/r/29789/diff/1/?file=815645#file815645line167>
> >
> >     would be wise to validate input and not assume
> 
> Robert Levas wrote:
>     To handle backward compatibility, "service" is assumed.  Maybe the default could
be assumed if this.type is null and throw an exception of the value is not "user" or "service"

sounds good


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29789/#review67646
-----------------------------------------------------------


On Jan. 13, 2015, 10:21 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29789/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 10:21 a.m.)
> 
> 
> Review request for Ambari, Emil Anca, Jaimin Jetly, John Speidel, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9077
>     https://issues.apache.org/jira/browse/AMBARI-9077
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add principal _type_ to Kerberos descriptor to declare whether is principal is a service
principal or a user principal.
> 
> This is needed for Active Directory since service principals needs to be created differently
than user principals. 
>  
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
0533228 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
a8eed2b 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
a6392da 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java
5f5d708 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java
60bdea8 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
ae2d4b2 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
04d43a5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java
6725c92 
>   ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalType.java
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/kerberos.json 9d3a38f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/kerberos.json 7882838

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/kerberos.json 6dd3e84

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/kerberos.json 9f9a4ea

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/kerberos.json e2d1d88

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/kerberos.json 5db86cd

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/kerberos.json 5c4b458

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/kerberos.json 77f4fe4

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json a31fbb8

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/kerberos.json b22d5fe

>   ambari-server/src/test/java/org/apache/ambari/server/agent/HeartBeatHandlerInjectKeytabTest.java
22eb31a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
8f39f21 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java
92a4100 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java
7958b6e 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java
72d58e2 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
d720da2 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
b61b76f 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
7a3308f 
>   ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
9d56dc2 
>   ambari-server/src/test/resources/stacks/HDP/2.0.8/kerberos.json 4308d81 
>   ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json 87c080e

> 
> Diff: https://reviews.apache.org/r/29789/diff/
> 
> 
> Testing
> -------
> 
> Tested in test custer
> Updated relevant unit tests
> 
> Tests run: 2501, Failures: 0, Errors: 0, Skipped: 13
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:04 h
> [INFO] Finished at: 2015-01-09T23:39:27+00:00
> [INFO] Final Memory: 44M/478M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message