ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 29790: Rolling Upgrades: clients do not send information about their version on restart
Date Sat, 10 Jan 2015 12:40:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29790/#review67587
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/29790/#comment111635>

    There's no change here, so how will a client announce it's version when doing RU?  The
review overall looks like client .py scripts are doing the work on configure() when it should
do the same thing you have for servers on start(), but maybe on install()



ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
<https://reviews.apache.org/r/29790/#comment111632>

    Client scripts should not do this.  You should use the same type of change you made for
daemon start() methods, but for maybe install() not configure()?



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
<https://reviews.apache.org/r/29790/#comment111633>

    Client scripts should not do this.  You should use the same type of change you made for
daemon start() methods, but for maybe install() not configure()?



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
<https://reviews.apache.org/r/29790/#comment111634>

    Why would this be added here for config?


- Nate Cole


On Jan. 9, 2015, 10:17 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29790/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 10:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9081
>     https://issues.apache.org/jira/browse/AMBARI-9081
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See AMBARI-8995, after that changes master components have their version in the results
of START command, but clients do not execute this command and thus it's not possible to track
their new version. As the result some components of the cluster remain in non upgraded state
and it prevents from setting cluster to upgraded state and finalize upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py af02f37

>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
5c430df 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
6f37f50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
59dba8d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
3f19ce4 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
570b124 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
72b657f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
50bd822 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
59be175 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
6d8716f 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
6b88acb 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
a625295 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
5fc27f4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
a11a0b6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
568ee8e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
e40f8c0 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
878b50c 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
ecd41c5 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
b447003 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
9a3eb66 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
a43bda5 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py
d7bf5eb 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
2dd3835 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
5218f49 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py
33ced03 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py
db8f188 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
6d68f3e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
890c329 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
55f191e 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py
13ab77f 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
04cfb90 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
a8ead39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
57bd379 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
c4e2800 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
78a75f6 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
2b8c631 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
60b9bce 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
7d57983 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
626ceba 
> 
> Diff: https://reviews.apache.org/r/29790/diff/
> 
> 
> Testing
> -------
> 
> Copied files to a cluster, and verified that restarting the services showed the version
in structured_out of the host_role_command table.
> Unit test results are in-progress.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message