ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29778: Upgrade pack for Storm
Date Fri, 09 Jan 2015 21:17:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29778/#review67522
-----------------------------------------------------------


Looks good; one minor thing related to get_stack_to_component()


ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
<https://reviews.apache.org/r/29778/#comment111548>

    This will need,
      def get_stack_to_component(self):
        return {"HDP": "storm-client"}



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
<https://reviews.apache.org/r/29778/#comment111549>

    I will soon move the call to save_component_version_to_structured_out() from all of the
scripts to script.py



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
<https://reviews.apache.org/r/29778/#comment111550>

    This will also need,
      def get_stack_to_component(self):
        return {"HDP": "storm-nimbus"}



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
<https://reviews.apache.org/r/29778/#comment111552>

    This will need,
      def get_stack_to_component(self):
        return {"HDP": "storm-supervisor"}



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
<https://reviews.apache.org/r/29778/#comment111553>

    This will need,
      def get_stack_to_component(self):
        return {"HDP": "storm-client"}


- Alejandro Fernandez


On Jan. 9, 2015, 9:09 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29778/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 9:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-9067
>     https://issues.apache.org/jira/browse/AMBARI-9067
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Storm upgrade will include a manual pre-upgrade task
> {{Deactivate and kill your currently running topology.}}
> and a manual post-upgrade task
> {{Rebuild your topology and resubmit the topology using the new jar.}}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
149b212 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
6d68f3e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
a1f8afe 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params.py
6d49d04 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
890c329 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
55f191e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
7aecdc5 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
6a9d923 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ed6b50c 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 336aded 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py d9887d4 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py 6c7ea30 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 4e29ffa

>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py 699dce8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 4ae0c4d

>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py becd591 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json 9f22fe8 
> 
> Diff: https://reviews.apache.org/r/29778/diff/
> 
> 
> Testing
> -------
> 
> New unit tests added.  All tests pass.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message