ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29775: Pre-Upgrade Check shows incorrect check results and blocks the user from proceeding
Date Fri, 09 Jan 2015 20:53:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29775/#review67512
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Jan. 9, 2015, 7:20 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29775/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 7:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9076
>     https://issues.apache.org/jira/browse/AMBARI-9076
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Pre-Upgrade Check complained that the repo version did not exist on any of the hosts
when it clearly did (checked API response, checked repo_version and host_version tables to
make sure repo and stack versions existed and that they were distributed to all hosts in the
cluster).
> This prevents the user from proceeding with RU.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/PreUpgradeCheckRequest.java
86619e8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
009b5fe 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
4d16a83 
> 
> Diff: https://reviews.apache.org/r/29775/diff/
> 
> 
> Testing
> -------
> 
> Tests ok
> 
> Note that there are no test changes as preupgrade checks are still lacking of unit-tests.
This problem is listed in technical debt ticket.
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message