ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete upgrade states in DB
Date Fri, 09 Jan 2015 18:55:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review67474
-----------------------------------------------------------


Thanks for getting this in. This will leave us in a good state to be one step closer to end-to-end
happy path.


ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/29771/#comment111513>

    We should not check the type of command, but only that structuredOut is not empty. Otherwise,
the configure commands cannot advertise the version.



ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/29771/#comment111514>

    Typo in "StructuredOut"



ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/29771/#comment111519>

    Can the recalculate happen after all of the CommandReports on the host have been iterated
over? This should improve performance.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
<https://reviews.apache.org/r/29771/#comment111520>

    Thank you for removing this.



ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
<https://reviews.apache.org/r/29771/#comment111523>

    Should also check that the version != UNKNOWN



ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
<https://reviews.apache.org/r/29771/#comment111522>

    We should not need to distinguish between masters vs clients. So this if-block should
not be needed.



ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
<https://reviews.apache.org/r/29771/#comment111524>

    Instead, check that upgradedHostComponents.size() > 0 and that they all have the same
version value.


- Alejandro Fernandez


On Jan. 9, 2015, 6:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9073
>     https://issues.apache.org/jira/browse/AMBARI-9073
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
11f2c14 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
7894de8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
74e2371 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
0b9525a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
53c8cff 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
e86ca1a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4b915aa 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
b89b31c 
> 
> Diff: https://reviews.apache.org/r/29771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message