ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29769: Upgrade Pack for Oozie
Date Fri, 09 Jan 2015 18:26:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29769/#review67470
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
<https://reviews.apache.org/r/29769/#comment111501>

    In the future, other stacks may have their own logic for how to do pre_rolling_restart,
so I suggest for consistency keeping the hdp-select logic inside the "if" block that checks
the hdp stack version.



ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
<https://reviews.apache.org/r/29769/#comment111503>

    Similar comment as above.



ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py
<https://reviews.apache.org/r/29769/#comment111504>

    Thank you for switching to named imports


- Alejandro Fernandez


On Jan. 9, 2015, 6:08 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29769/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 6:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-9072
>     https://issues.apache.org/jira/browse/AMBARI-9072
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create the HDP upgrade pack for Oozie according to the runbook. The following steps will
be performed:
> 
> - Backup and restoration of Oozie configuration files
> - Backup of Oozie database
> - Installation of a new sharelib in HDFS
> - Preparation of the new Oozie WAR
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
a7313f3 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
a129bce 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
59966fd 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py
57ea5c1 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ed6b50c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 4324040 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29769/diff/
> 
> 
> Testing
> -------
> 
> OK
> ----------------------------------------------------------------------
> Total run:572
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message