ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Review Request 29766: Service check for Storm Fails
Date Fri, 09 Jan 2015 16:33:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29766/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Nate Cole.


Bugs: AMBARI-9066
    https://issues.apache.org/jira/browse/AMBARI-9066


Repository: ambari


Description
-------

AMBARI - 1.6.0
PROBLEM DESCRIPTION: After deploying the custom agent packages the install goes through okay.
However service check for storm fails with the attached error messages.
BUSINESS IMPACT: Operational issue. Ops team has issues with checking service availability
once it starts up
ACTUAL BEHAVIOR: See screen shot attached
EXPECTED BEHAVIOR: Service check to return successful


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py
0f1f012 
  ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py
dbd54a7 
  ambari-common/src/main/python/resource_management/libraries/providers/execute_hadoop.py
c3ec7c7 
  ambari-common/src/main/python/resource_management/libraries/providers/monitor_webserver.py
7d2c1e1 
  ambari-common/src/main/python/resource_management/libraries/providers/properties_file.py
94a51ff 
  ambari-common/src/main/python/resource_management/libraries/providers/repository.py a0ad8f9

  ambari-common/src/main/python/resource_management/libraries/providers/template_config.py
4972797 
  ambari-common/src/main/python/resource_management/libraries/providers/xml_config.py 5f30190

  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
149b212 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
6d68f3e 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
a1f8afe 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params.py
6d49d04 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
890c329 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py
ed6add5 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_check.py
2661e6f 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py
5eaa446 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
3b71751 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
55f191e 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
7aecdc5 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisord_service.py
6a5ea0b 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
6a9d923 

Diff: https://reviews.apache.org/r/29766/diff/


Testing
-------

Patch causes unit tests to fail with multiple import errors. But this patch works on machines
of other devs without failures. Reviewers, please check unit tests run on your machine and
ship patch if it passes.

ERROR: test_configure_default (test_storm_supervisor_prod.TestStormSupervisor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py",
line 97, in test_configure_default
    target = RMFTestCase.TARGET_COMMON_SERVICES
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
line 110, in executeScript
    script_module = imp.load_source(classname, script_path)
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py",
line 27, in <module>
    class Supervisor(Script):
NameError: name 'Script' is not defined

ERROR: test_start_default (test_storm_supervisor_prod.TestStormSupervisor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py",
line 45, in test_start_default
    target = RMFTestCase.TARGET_COMMON_SERVICES
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
line 110, in executeScript
    script_module = imp.load_source(classname, script_path)
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py",
line 27, in <module>
    class Supervisor(Script):
NameError: name 'Script' is not defined


ERROR: test_start_secured (test_storm_supervisor_prod.TestStormSupervisor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py",
line 108, in test_start_secured
    target = RMFTestCase.TARGET_COMMON_SERVICES
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
line 110, in executeScript
    script_module = imp.load_source(classname, script_path)
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py",
line 27, in <module>
    class Supervisor(Script):
NameError: name 'Script' is not defined

ERROR: test_stop_default (test_storm_supervisor_prod.TestStormSupervisor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py",
line 74, in test_stop_default
    target = RMFTestCase.TARGET_COMMON_SERVICES
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
line 110, in executeScript
    script_module = imp.load_source(classname, script_path)
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py",
line 27, in <module>
    class Supervisor(Script):
NameError: name 'Script' is not defined

ERROR: test_stop_secured (test_storm_supervisor_prod.TestStormSupervisor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py",
line 137, in test_stop_secured
    target = RMFTestCase.TARGET_COMMON_SERVICES
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
line 110, in executeScript
    script_module = imp.load_source(classname, script_path)
  File "/media/plextor/review_ambari/ambari-server/src/test/python/stacks/utils/../../../../main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py",
line 27, in <module>
    class Supervisor(Script):
NameError: name 'Script' is not defined

----------------------------------------------------------------------
Total run:570
Total errors:5


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message