ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andriy Babiichuk" <ababiic...@hortonworks.com>
Subject Re: Review Request 29762: Upgrade Progress popup tweaks
Date Fri, 09 Jan 2015 12:17:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29762/#review67424
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Янв. 9, 2015, 12:10 п.п., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29762/
> -----------------------------------------------------------
> 
> (Updated Янв. 9, 2015, 12:10 п.п.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-9049
>     https://issues.apache.org/jira/browse/AMBARI-9049
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Upgrade Groups and Upgrade Items are sorted in reverse, and pending ones are hidden.
This way, the current Upgrade Groups/Items always show up at the very top and does not get
pushed down towards the bottom (or even off) of the page. 
> 2. The box showing the currently executing task / manual steps / failure has been moved
to the top as well, and this is always showing no matter what (currently, it gets hidden once
you drill down, which creates confusion)
> 3. Added "view details" / "hide details" toggle on the box. Upon clicking "view details",
the box expands and stdout/stderr info is shown. Upon clicking "hide details", the stdout/stderr
is hidden. 
> 4. Change "Currently Running" to "Now Running".
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/data/stack_versions/upgrade.json 93f666c 
>   ambari-web/app/messages.js 096662e 
>   ambari-web/app/models/upgrade_entity.js 3af06f2 
>   ambari-web/app/styles/application.less 967fad1 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 3fec992

>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_group.hbs 31be899 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_task.hbs 4dff7ed 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_group_view.js 92bc291 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_task_view.js bc5b006 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js bbfd067 
>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_group_view_test.js 249764f 
>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js d195696

> 
> Diff: https://reviews.apache.org/r/29762/diff/
> 
> 
> Testing
> -------
> 
>   5202 tests complete (9 seconds)
>   60 tests pending
>   
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message