ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 29701: Design admin principal session expiration handling API call
Date Thu, 08 Jan 2015 16:50:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29701/#review67207
-----------------------------------------------------------

Ship it!


Looks good.

- Robert Nettleton


On Jan. 8, 2015, 4:29 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29701/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 4:29 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9014
>     https://issues.apache.org/jira/browse/AMBARI-9014
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Provide the standard error code that will be returned along with the error message.
> 
> If administrative credentials are not available
> {
>   "status" : 400,
>   "message" : "java.lang.IllegalArgumentException: Missing KDC administrator credentials"
> }
> 
> If administrative credentials are not valid, for example, incorrect principal or password
(or keytab)
> {
>   "status" : 400,
>   "message" : "java.lang.IllegalArgumentException: Invalid KDC administrator credentials"
> }
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
9662669 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
0533228 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
ae2d4b2 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java
30e3c35 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
a99628c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
8f39f21 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactoryTest.java
4c7e49d 
> 
> Diff: https://reviews.apache.org/r/29701/diff/
> 
> 
> Testing
> -------
> 
> Manaully tested in test cluster
> 
> #Jenkins Test Results
> 
> Running org.apache.ambari.server.controller.KerberosHelperTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.632 sec
> 
> Running org.apache.ambari.server.stack.KerberosDescriptorTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.19 sec
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:00 h
> [INFO] Finished at: 2015-01-08T04:22:16+00:00
> [INFO] Final Memory: 44M/513M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message