ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Review Request 29593: AMS : Yarn service - RPC metrics returns duplicate array elements.
Date Mon, 05 Jan 2015 22:21:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29593/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.


Bugs: AMBARI-8994
    https://issues.apache.org/jira/browse/AMBARI-8994


Repository: ambari


Description
-------

API call:
{code}
http://localhost:8080/api/v1/clusters/cl1/hosts/ambari-api-tests-20-4.cs1cloud.internal/host_components/RESOURCEMANAGER?fields=metrics/rpc/RpcQueueTime_avg_time[1419970008,1419973608,15]
{code}
- Every 8th timestamp is duplicated.
- AMS should be able to handle this.


Diffs
-----

  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
PRE-CREATION 
  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/base/AbstractTimelineMetricsSink.java
d51ee67 
  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
06c3441 
  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
d28b345 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
fb061a9 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
3c83868 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
a8f35e4 

Diff: https://reviews.apache.org/r/29593/diff/


Testing
-------


Thanks,

Sid Wagle


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message